fix: re-throw original exception and preserve message in compute client #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
==========================================
+ Coverage 88.14% 88.32% +0.18%
==========================================
Files 18 18
Lines 776 771 -5
Branches 84 83 -1
==========================================
- Hits 684 681 -3
+ Misses 81 79 -2
Partials 11 11
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
==========================================
+ Coverage 88.14% 88.29% +0.15%
==========================================
Files 18 18
Lines 776 769 -7
Branches 84 83 -1
==========================================
- Hits 684 679 -5
+ Misses 81 79 -2
Partials 11 11
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #532. The original error message returned from the GCE metadata service was getting swallowed. This ensures the underlying exception is thrown, and the message is preserved.