Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve local user experience for User Credentials #1525

Closed
TimurSadykov opened this issue Feb 25, 2023 · 1 comment
Closed

Improve local user experience for User Credentials #1525

TimurSadykov opened this issue Feb 25, 2023 · 1 comment
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@TimurSadykov
Copy link
Member

This is part of the bigger work go/simplified-local-adc

User Credentials are now recommended for local development per go/mitigating-cloud-auth-risk

However, some errors and warnings still refer to service accounts (see section 1.2 of the go/simplified-local-adc):

  1. When user does not have credential setup, we do not recommend setting up service account, rather we redirect to a new ADC setup page.
  2. (if applicable) We show warning about user credentials only if production environment is detected
    Reference Java fix: fix: improve errors and warnings related to ADC google-auth-library-java#1172
@TimurSadykov TimurSadykov added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Feb 25, 2023
@danielbankhead danielbankhead self-assigned this Mar 3, 2023
@danielbankhead danielbankhead added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels May 11, 2023
@danielbankhead
Copy link
Member

danielbankhead commented May 12, 2023

Today, we don't offer suggestions in the code suggesting service accounts or not (in docs, comments, or error messages). Here's how the missing ADC message looks like today:

// We failed to find the default credentials. Bail out with an error.
throw new Error(
'Could not load the default credentials. Browse to https://cloud.google.com/docs/authentication/getting-started for more information.'
);

As for the second case:

I'm happy to revert #905 if the telemetry determines this provides a better user experience.

Let me know if anything else, closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants