fix: do not suppress external project ID determination errors #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not suppress the underlying error, as the error could contain helpful information for debugging and fixing. This is especially true for external account creds as in order to get the project ID, the following operations have to succeed: 1. Valid credentials file should be supplied. 2. Ability to retrieve access tokens from STS token exchange API. 3. Ability to exchange for service account impersonated credentials (if enabled). 4. Ability to get project info using the access token from step 2 or 3. Without surfacing the error, it is harder for developers to determine which step went wrong.
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1153 +/- ##
=======================================
Coverage 93.75% 93.76%
=======================================
Files 28 28
Lines 6260 6267 +7
Branches 656 611 -45
=======================================
+ Hits 5869 5876 +7
Misses 391 391
Continue to review full report at Codecov.
|
|
@bcoe I believe this should be a safe change to make. This is an unrecoverable error that is typically thrown during development and setup. It is now returning a clearer error message. An internal team member was having issues with it and surfaced it. Let me know if you have any questions. |
bcoe
approved these changes
Apr 6, 2021
bcoe
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not suppress the underlying error, as the error could contain helpful
information for debugging and fixing. This is especially true for
external account creds as in order to get the project ID, the following
operations have to succeed:
enabled).
Without surfacing the error, it is harder for developers to determine
which step went wrong.