Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move accessToken to headers instead of parameter #1108

Merged
merged 5 commits into from Dec 18, 2020
Merged

fix: move accessToken to headers instead of parameter #1108

merged 5 commits into from Dec 18, 2020

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Dec 17, 2020

Fixes #980

@sofisl sofisl requested a review from bcoe December 17, 2020 19:16
@sofisl sofisl requested a review from a team as a code owner December 17, 2020 19:16
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2020
@codecov
Copy link

codecov bot commented Dec 17, 2020 •
edited

Codecov Report

Merging #1108 (6993c1d) into master (bf5ced3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1108   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files          21       21           
  Lines        4145     4145           
  Branches      461      461           
=======================================
  Hits         3798     3798           
  Misses        347      347
Impacted Files Coverage Δ
src/auth/oauth2client.ts 96.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5ced3...6993c1d. Read the comment docs.

bcoe
bcoe approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/auth/oauth2client.ts Outdated Show resolved Hide resolved
src/auth/oauth2client.ts Outdated Show resolved Hide resolved
@bcoe bcoe merged commit 67b0cc3 into master Dec 18, 2020
@bcoe bcoe deleted the bug980 branch December 18, 2020 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees

@bcoe bcoe

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send access_token for token info method as a header instead of as URL params
2 participants
@sofisl @bcoe