-
Notifications
You must be signed in to change notification settings - Fork 371
/
test.downscopedclient.ts
712 lines (663 loc) Β· 23.7 KB
/
test.downscopedclient.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
// Copyright 2021 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
import * as assert from 'assert';
import {describe, it, beforeEach, afterEach} from 'mocha';
import * as nock from 'nock';
import * as sinon from 'sinon';
import {GaxiosOptions, GaxiosPromise} from 'gaxios';
import {Credentials} from '../src/auth/credentials';
import {StsSuccessfulResponse} from '../src/auth/stscredentials';
import {
DownscopedClient,
CredentialAccessBoundary,
MAX_ACCESS_BOUNDARY_RULES_COUNT,
} from '../src/auth/downscopedclient';
import {AuthClient} from '../src/auth/authclient';
import {mockStsTokenExchange} from './externalclienthelper';
import {
OAuthErrorResponse,
getErrorFromOAuthErrorResponse,
} from '../src/auth/oauth2common';
import {GetAccessTokenResponse, Headers} from '../src/auth/oauth2client';
nock.disableNetConnect();
/** A dummy class used as source credential for testing. */
class TestAuthClient extends AuthClient {
public throwError = false;
private counter = 0;
async getAccessToken(): Promise<GetAccessTokenResponse> {
if (!this.throwError) {
// Increment subject_token counter each time this is called.
return {
token: `subject_token_${this.counter++}`,
};
}
throw new Error('Cannot get subject token.');
}
set expirationTime(expirationTime: number | undefined | null) {
this.credentials.expiry_date = expirationTime;
}
async getRequestHeaders(url?: string): Promise<Headers> {
throw new Error('Not implemented.');
}
request<T>(opts: GaxiosOptions): GaxiosPromise<T> {
throw new Error('Not implemented.');
}
}
interface SampleResponse {
foo: string;
bar: number;
}
describe('DownscopedClient', () => {
let clock: sinon.SinonFakeTimers;
let client: TestAuthClient;
const ONE_HOUR_IN_SECS = 3600;
const testAvailableResource =
'//storage.googleapis.com/projects/_/buckets/bucket-123';
const testAvailablePermission1 = 'inRole:roles/storage.objectViewer';
const testAvailablePermission2 = 'inRole:roles/storage.objectAdmin';
const testAvailabilityConditionExpression =
"resource.name.startsWith('projects/_/buckets/bucket-123/objects/prefix')";
const testAvailabilityConditionTitle = 'Test availability condition title.';
const testAvailabilityConditionDescription =
'Test availability condition description.';
const testClientAccessBoundary = {
accessBoundary: {
accessBoundaryRules: [
{
availableResource: testAvailableResource,
availablePermissions: [testAvailablePermission1],
availabilityCondition: {
expression: testAvailabilityConditionExpression,
},
},
],
},
};
const stsSuccessfulResponse: StsSuccessfulResponse = {
access_token: 'DOWNSCOPED_CLIENT_ACCESS_TOKEN_0',
issued_token_type: 'urn:ietf:params:oauth:token-type:access_token',
token_type: 'Bearer',
expires_in: ONE_HOUR_IN_SECS,
};
/**
* Offset to take into account network delays and server clock skews.
*/
const EXPIRATION_TIME_OFFSET = 5 * 60 * 1000;
beforeEach(async () => {
client = new TestAuthClient();
});
afterEach(() => {
nock.cleanAll();
if (clock) {
clock.restore();
}
});
describe('Constructor', () => {
it('should throw on empty access boundary rule', () => {
const expectedError = new Error(
'At least one access boundary rule needs to be defined.'
);
const cabWithEmptyAccessBoundaryRules = {
accessBoundary: {
accessBoundaryRules: [],
},
};
assert.throws(() => {
return new DownscopedClient(client, cabWithEmptyAccessBoundaryRules);
}, expectedError);
});
it('should throw when number of access boundary rules is exceeded', () => {
const expectedError = new Error(
'The provided access boundary has more than ' +
`${MAX_ACCESS_BOUNDARY_RULES_COUNT} access boundary rules.`
);
const cabWithExceedingAccessBoundaryRules: CredentialAccessBoundary = {
accessBoundary: {
accessBoundaryRules: [],
},
};
const testAccessBoundaryRule = {
availableResource: testAvailableResource,
availablePermissions: [testAvailablePermission1],
availabilityCondition: {
expression: testAvailabilityConditionExpression,
},
};
for (let num = 0; num <= MAX_ACCESS_BOUNDARY_RULES_COUNT; num++) {
cabWithExceedingAccessBoundaryRules.accessBoundary.accessBoundaryRules.push(
testAccessBoundaryRule
);
}
assert.throws(() => {
return new DownscopedClient(
client,
cabWithExceedingAccessBoundaryRules
);
}, expectedError);
});
it('should throw on no permissions are defined in access boundary rules', () => {
const expectedError = new Error(
'At least one permission should be defined in access boundary rules.'
);
const cabWithNoPermissionIncluded = {
accessBoundary: {
accessBoundaryRules: [
{
availableResource: testAvailableResource,
availablePermissions: [],
availabilityCondition: {
expression: testAvailabilityConditionExpression,
},
},
],
},
};
assert.throws(() => {
return new DownscopedClient(client, cabWithNoPermissionIncluded);
}, expectedError);
});
it('should not throw on one access boundary rule with all fields included', () => {
const cabWithOneAccessBoundaryRule = {
accessBoundary: {
accessBoundaryRules: [
{
availableResource: testAvailableResource,
availablePermissions: [testAvailablePermission1],
availabilityCondition: {
expression: testAvailabilityConditionExpression,
},
},
],
},
};
assert.doesNotThrow(() => {
return new DownscopedClient(client, cabWithOneAccessBoundaryRule);
});
});
it('should not throw with multiple permissions defined', () => {
const cabWithTwoAvailblePermissions = {
accessBoundary: {
accessBoundaryRules: [
{
availableResource: testAvailableResource,
availablePermissions: [
testAvailablePermission1,
testAvailablePermission2,
],
availabilityCondition: {
expression: testAvailabilityConditionExpression,
title: testAvailabilityConditionTitle,
description: testAvailabilityConditionDescription,
},
},
],
},
};
assert.doesNotThrow(() => {
return new DownscopedClient(client, cabWithTwoAvailblePermissions);
});
});
it('should not throw with empty available condition', () => {
const cabWithNoAvailabilityCondition = {
accessBoundary: {
accessBoundaryRules: [
{
availableResource: testAvailableResource,
availablePermissions: [testAvailablePermission1],
},
],
},
};
assert.doesNotThrow(() => {
return new DownscopedClient(client, cabWithNoAvailabilityCondition);
});
});
it('should not throw with only expression setup in available condition', () => {
const cabWithOnlyAvailabilityConditionExpression = {
accessBoundary: {
accessBoundaryRules: [
{
availableResource: testAvailableResource,
availablePermissions: [
testAvailablePermission1,
testAvailablePermission2,
],
availabilityCondition: {
expression: testAvailabilityConditionExpression,
},
},
],
},
};
assert.doesNotThrow(() => {
return new DownscopedClient(
client,
cabWithOnlyAvailabilityConditionExpression
);
});
});
it('should set custom RefreshOptions', () => {
const refreshOptions = {
eagerRefreshThresholdMillis: 5000,
forceRefreshOnFailure: true,
};
const cabWithOneAccessBoundaryRules = {
accessBoundary: {
accessBoundaryRules: [
{
availableResource: testAvailableResource,
availablePermissions: [testAvailablePermission1],
availabilityCondition: {
expression: testAvailabilityConditionExpression,
},
},
],
},
};
const downscopedClient = new DownscopedClient(
client,
cabWithOneAccessBoundaryRules,
refreshOptions
);
assert.strictEqual(
downscopedClient.forceRefreshOnFailure,
refreshOptions.forceRefreshOnFailure
);
assert.strictEqual(
downscopedClient.eagerRefreshThresholdMillis,
refreshOptions.eagerRefreshThresholdMillis
);
});
});
describe('setCredential()', () => {
it('should throw error if no expire time is set in credential', async () => {
const credentials = {
access_token: 'DOWNSCOPED_CLIENT_ACCESS_TOKEN',
};
const expectedError = new Error(
'The access token expiry_date field is missing in the provided ' +
'credentials.'
);
const downscopedClient = new DownscopedClient(
client,
testClientAccessBoundary
);
assert.throws(() => {
downscopedClient.setCredentials(credentials);
}, expectedError);
});
it('should not throw error if expire time is set in credential', async () => {
const now = new Date().getTime();
const credentials = {
access_token: 'DOWNSCOPED_CLIENT_ACCESS_TOKEN',
expiry_date: now + ONE_HOUR_IN_SECS * 1000,
};
const downscopedClient = new DownscopedClient(
client,
testClientAccessBoundary
);
assert.doesNotThrow(() => {
downscopedClient.setCredentials(credentials);
});
const tokenResponse = await downscopedClient.getAccessToken();
assert.deepStrictEqual(tokenResponse.token, credentials.access_token);
assert.deepStrictEqual(
tokenResponse.expirationTime,
credentials.expiry_date
);
});
});
describe('getAccessToken()', () => {
it('should return current unexpired cached DownscopedClient access token', async () => {
const now = new Date().getTime();
clock = sinon.useFakeTimers(now);
const credentials = {
access_token: 'DOWNSCOPED_CLIENT_ACCESS_TOKEN',
expiry_date: now + ONE_HOUR_IN_SECS * 1000,
};
const downscopedClient = new DownscopedClient(
client,
testClientAccessBoundary
);
downscopedClient.setCredentials(credentials);
const tokenResponse = await downscopedClient.getAccessToken();
assert.deepStrictEqual(tokenResponse.token, credentials.access_token);
assert.deepStrictEqual(
tokenResponse.expirationTime,
credentials.expiry_date
);
assert.deepStrictEqual(
tokenResponse.token,
downscopedClient.credentials.access_token
);
assert.deepStrictEqual(
tokenResponse.expirationTime,
downscopedClient.credentials.expiry_date
);
clock.tick(ONE_HOUR_IN_SECS * 1000 - EXPIRATION_TIME_OFFSET - 1);
const cachedTokenResponse = await downscopedClient.getAccessToken();
assert.deepStrictEqual(
cachedTokenResponse.token,
credentials.access_token
);
assert.deepStrictEqual(
cachedTokenResponse.expirationTime,
credentials.expiry_date
);
});
it('should refresh a new DownscopedClient access when cached one gets expired', async () => {
const now = new Date().getTime();
clock = sinon.useFakeTimers(now);
const emittedEvents: Credentials[] = [];
const credentials = {
access_token: 'DOWNSCOPED_CLIENT_ACCESS_TOKEN',
expiry_date: now + ONE_HOUR_IN_SECS * 1000,
};
const scope = mockStsTokenExchange([
{
statusCode: 200,
response: stsSuccessfulResponse,
request: {
grant_type: 'urn:ietf:params:oauth:grant-type:token-exchange',
requested_token_type:
'urn:ietf:params:oauth:token-type:access_token',
subject_token: 'subject_token_0',
subject_token_type: 'urn:ietf:params:oauth:token-type:access_token',
options: JSON.stringify(testClientAccessBoundary),
},
},
]);
const downscopedClient = new DownscopedClient(
client,
testClientAccessBoundary
);
// Listen to tokens events. On every event, push to list of
// emittedEvents.
downscopedClient.on('tokens', tokens => {
emittedEvents.push(tokens);
});
downscopedClient.setCredentials(credentials);
clock.tick(ONE_HOUR_IN_SECS * 1000 - EXPIRATION_TIME_OFFSET - 1);
const tokenResponse = await downscopedClient.getAccessToken();
// No new event should be triggered since the cached access token is
// returned.
assert.strictEqual(emittedEvents.length, 0);
assert.deepStrictEqual(tokenResponse.token, credentials.access_token);
clock.tick(1);
const refreshedTokenResponse = await downscopedClient.getAccessToken();
const responseExpiresIn = stsSuccessfulResponse.expires_in as number;
const expectedExpirationTime =
credentials.expiry_date +
responseExpiresIn * 1000 -
EXPIRATION_TIME_OFFSET;
// tokens event should be triggered once with expected event.
assert.strictEqual(emittedEvents.length, 1);
assert.deepStrictEqual(emittedEvents[0], {
refresh_token: null,
expiry_date: expectedExpirationTime,
access_token: stsSuccessfulResponse.access_token,
token_type: 'Bearer',
id_token: null,
});
assert.deepStrictEqual(
refreshedTokenResponse.token,
stsSuccessfulResponse.access_token
);
assert.deepStrictEqual(
refreshedTokenResponse.expirationTime,
expectedExpirationTime
);
assert.deepStrictEqual(
refreshedTokenResponse.token,
downscopedClient.credentials.access_token
);
assert.deepStrictEqual(
refreshedTokenResponse.expirationTime,
downscopedClient.credentials.expiry_date
);
scope.done();
});
it('should return new access token when no cached token is available', async () => {
const scope = mockStsTokenExchange([
{
statusCode: 200,
response: stsSuccessfulResponse,
request: {
grant_type: 'urn:ietf:params:oauth:grant-type:token-exchange',
requested_token_type:
'urn:ietf:params:oauth:token-type:access_token',
subject_token: 'subject_token_0',
subject_token_type: 'urn:ietf:params:oauth:token-type:access_token',
options: JSON.stringify(testClientAccessBoundary),
},
},
]);
const downscopedClient = new DownscopedClient(
client,
testClientAccessBoundary
);
assert.deepStrictEqual(downscopedClient.credentials, {});
const tokenResponse = await downscopedClient.getAccessToken();
assert.deepStrictEqual(
tokenResponse.token,
stsSuccessfulResponse.access_token
);
assert.deepStrictEqual(
tokenResponse.token,
downscopedClient.credentials.access_token
);
assert.deepStrictEqual(
tokenResponse.expirationTime,
downscopedClient.credentials.expiry_date
);
scope.done();
});
it('should handle underlying token exchange errors', async () => {
const errorResponse: OAuthErrorResponse = {
error: 'invalid_request',
error_description: 'Invalid subject token',
error_uri: 'https://tools.ietf.org/html/rfc6749#section-5.2',
};
const scope = mockStsTokenExchange([
{
statusCode: 400,
response: errorResponse,
request: {
grant_type: 'urn:ietf:params:oauth:grant-type:token-exchange',
requested_token_type:
'urn:ietf:params:oauth:token-type:access_token',
subject_token: 'subject_token_0',
subject_token_type: 'urn:ietf:params:oauth:token-type:access_token',
options: JSON.stringify(testClientAccessBoundary),
},
},
{
statusCode: 200,
response: stsSuccessfulResponse,
request: {
grant_type: 'urn:ietf:params:oauth:grant-type:token-exchange',
requested_token_type:
'urn:ietf:params:oauth:token-type:access_token',
subject_token: 'subject_token_1',
subject_token_type: 'urn:ietf:params:oauth:token-type:access_token',
options: JSON.stringify(testClientAccessBoundary),
},
},
]);
const downscopedClient = new DownscopedClient(
client,
testClientAccessBoundary
);
assert.deepStrictEqual(downscopedClient.credentials, {});
await assert.rejects(
downscopedClient.getAccessToken(),
getErrorFromOAuthErrorResponse(errorResponse)
);
assert.deepStrictEqual(downscopedClient.credentials, {});
// Next try should succeed.
const actualResponse = await downscopedClient.getAccessToken();
delete actualResponse.res;
assert.deepStrictEqual(
actualResponse.token,
stsSuccessfulResponse.access_token
);
assert.deepStrictEqual(
actualResponse.token,
downscopedClient.credentials.access_token
);
assert.deepStrictEqual(
actualResponse.expirationTime,
downscopedClient.credentials.expiry_date
);
scope.done();
});
it('should throw when the source AuthClient rejects on token request', async () => {
const expectedError = new Error('Cannot get subject token.');
client.throwError = true;
const downscopedClient = new DownscopedClient(
client,
testClientAccessBoundary
);
await assert.rejects(downscopedClient.getAccessToken(), expectedError);
});
it('should copy source cred expiry time if STS response does not return expiry time', async () => {
const now = new Date().getTime();
const expireDate = now + ONE_HOUR_IN_SECS * 1000;
const stsSuccessfulResponseWithoutExpireInField = Object.assign(
{},
stsSuccessfulResponse
);
const emittedEvents: Credentials[] = [];
delete stsSuccessfulResponseWithoutExpireInField.expires_in;
const scope = mockStsTokenExchange([
{
statusCode: 200,
response: stsSuccessfulResponseWithoutExpireInField,
request: {
grant_type: 'urn:ietf:params:oauth:grant-type:token-exchange',
requested_token_type:
'urn:ietf:params:oauth:token-type:access_token',
subject_token: 'subject_token_0',
subject_token_type: 'urn:ietf:params:oauth:token-type:access_token',
options: JSON.stringify(testClientAccessBoundary),
},
},
]);
client.expirationTime = expireDate;
const downscopedClient = new DownscopedClient(
client,
testClientAccessBoundary
);
// Listen to tokens events. On every event, push to list of
// emittedEvents.
downscopedClient.on('tokens', tokens => {
emittedEvents.push(tokens);
});
const tokenResponse = await downscopedClient.getAccessToken();
// tokens event should be triggered once with expected event.
assert.strictEqual(emittedEvents.length, 1);
assert.deepStrictEqual(emittedEvents[0], {
refresh_token: null,
expiry_date: expireDate,
access_token: stsSuccessfulResponseWithoutExpireInField.access_token,
token_type: 'Bearer',
id_token: null,
});
assert.deepStrictEqual(tokenResponse.expirationTime, expireDate);
assert.deepStrictEqual(
tokenResponse.token,
stsSuccessfulResponseWithoutExpireInField.access_token
);
assert.strictEqual(downscopedClient.credentials.expiry_date, expireDate);
assert.strictEqual(
downscopedClient.credentials.access_token,
stsSuccessfulResponseWithoutExpireInField.access_token
);
scope.done();
});
it('should have no expiry date if source cred has no expiry time and STS response does not return one', async () => {
const stsSuccessfulResponseWithoutExpireInField = Object.assign(
{},
stsSuccessfulResponse
);
const emittedEvents: Credentials[] = [];
delete stsSuccessfulResponseWithoutExpireInField.expires_in;
const scope = mockStsTokenExchange([
{
statusCode: 200,
response: stsSuccessfulResponseWithoutExpireInField,
request: {
grant_type: 'urn:ietf:params:oauth:grant-type:token-exchange',
requested_token_type:
'urn:ietf:params:oauth:token-type:access_token',
subject_token: 'subject_token_0',
subject_token_type: 'urn:ietf:params:oauth:token-type:access_token',
options: JSON.stringify(testClientAccessBoundary),
},
},
]);
const downscopedClient = new DownscopedClient(
client,
testClientAccessBoundary
);
// Listen to tokens events. On every event, push to list of
// emittedEvents.
downscopedClient.on('tokens', tokens => {
emittedEvents.push(tokens);
});
const tokenResponse = await downscopedClient.getAccessToken();
// tokens event should be triggered once with expected event.
assert.strictEqual(emittedEvents.length, 1);
assert.deepStrictEqual(emittedEvents[0], {
refresh_token: null,
expiry_date: null,
access_token: stsSuccessfulResponseWithoutExpireInField.access_token,
token_type: 'Bearer',
id_token: null,
});
assert.deepStrictEqual(
tokenResponse.token,
stsSuccessfulResponseWithoutExpireInField.access_token
);
assert.deepStrictEqual(tokenResponse.expirationTime, null);
assert.deepStrictEqual(downscopedClient.credentials.expiry_date, null);
scope.done();
});
});
describe('getRequestHeader()', () => {
it('should return unimplemented error when calling getRequestHeader()', async () => {
const expectedError = new Error('Not implemented.');
const cabClient = new DownscopedClient(client, testClientAccessBoundary);
await assert.rejects(cabClient.getRequestHeaders(), expectedError);
});
});
describe('request()', () => {
it('should return unimplemented error when request with opts', () => {
const cabClient = new DownscopedClient(client, testClientAccessBoundary);
const exampleRequest = {
key1: 'value1',
key2: 'value2',
};
const expectedError = new Error('Not implemented.');
assert.throws(() => {
return cabClient.request<SampleResponse>({
url: 'https://example.com/api',
method: 'POST',
data: exampleRequest,
responseType: 'json',
});
}, expectedError);
});
});
});