Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generating ID token with ImpersonatedCredentials does not support overriding quota project #977

Open
lzy-2022 opened this issue Aug 11, 2022 · 1 comment
Open

Generating ID token with ImpersonatedCredentials does not support overriding quota project #977

lzy-2022 opened this issue Aug 11, 2022 · 1 comment
Assignees
@TimurSadykov
Labels
help wanted We'd love to have community involvement on this issue. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@lzy-2022
Copy link

lzy-2022 commented Aug 11, 2022 •
edited by TimurSadykov

Is your feature request related to a problem? Please describe.
ImpersonatedCredentials accepts a quota project in its builder, and the quota project is properly overridden when generating an access token. However, when generating id token with the idTokenWithAudience() method, it won't perform such override. The impact is that if a service does impersonate many IdTokens on its own quota - it exceeds a default limit of 60k.

Describe the solution you'd like
It seems to me that providing the quota project in the additionalFields argument when invoking the IamUtils.getIdToken() method would work

Describe alternatives you've considered
There doesn't seem to be good alternatives.
@TimurSadykov TimurSadykov assigned lsirac and TimurSadykov and unassigned lsirac Aug 11, 2022
@TimurSadykov TimurSadykov added help wanted We'd love to have community involvement on this issue. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 16, 2022
@TimurSadykov
Copy link
Member

@sai-sunder-s what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimurSadykov TimurSadykov

Labels
help wanted We'd love to have community involvement on this issue. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@TimurSadykov @lsirac @lzy-2022 and others