Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make JwtClaims.newBuilder() public #350

Merged
merged 1 commit into from Sep 26, 2019
Merged

fix: make JwtClaims.newBuilder() public #350

merged 1 commit into from Sep 26, 2019

Conversation

chingor13
Copy link
Contributor

Fixes #349

@chingor13 chingor13 requested a review from a team as a code owner September 26, 2019 13:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2019
@codecov
Copy link

codecov bot commented Sep 26, 2019 •
edited

Codecov Report

Merging #350 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #350   +/-   ##
=========================================
  Coverage     79.67%   79.67%           
  Complexity      389      389           
=========================================
  Files            27       27           
  Lines          1761     1761           
  Branches        183      183           
=========================================
  Hits           1403     1403           
  Misses          262      262           
  Partials         96       96
Impacted Files Coverage Δ Complexity Δ
...h2_http/java/com/google/auth/oauth2/JwtClaims.java 92.3% <ø> (ø) 8 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e34aa...417846a. Read the comment docs.

@chingor13 chingor13 merged commit 6ab8758 into googleapis:master Sep 26, 2019
@chingor13 chingor13 deleted the public-builder branch September 26, 2019 15:22
@elharo
Copy link
Contributor

elharo commented Oct 9, 2019

since new API was added in JwtClaims this probably should be 0.18.0

@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why is JwtClaims.newBuilder() package private?
3 participants
@chingor13 @elharo @googlebot