Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Automatic-Module-Name to manifest #324

Closed
elharo opened this issue Aug 9, 2019 · 2 comments
Closed

Add Automatic-Module-Name to manifest #324

elharo opened this issue Aug 9, 2019 · 2 comments
Assignees
@chingor13
Labels
good first issue This issue is a good place to started contributing to this repository. help wanted We'd love to have community involvement on this issue. semver: patch A minor bug fix or small change. status: investigating The issue is under investigation, which is determined to be non-trivial.

Comments

@elharo
Copy link
Contributor

elharo commented Aug 9, 2019

https://github.com/GoogleCloudPlatform/cloud-opensource-java/blob/master/library-best-practices/JLBP-20.md
@elharo elharo added good first issue This issue is a good place to started contributing to this repository. help wanted We'd love to have community involvement on this issue. semver: patch A minor bug fix or small change. labels Aug 9, 2019
@man0s man0s mentioned this issue Aug 9, 2019
Closed
@elharo elharo added status: blocked Resolving the issue is dependent on other work. good first issue This issue is a good place to started contributing to this repository. help wanted We'd love to have community involvement on this issue. status: investigating The issue is under investigation, which is determined to be non-trivial. and removed good first issue This issue is a good place to started contributing to this repository. help wanted We'd love to have community involvement on this issue. status: blocked Resolving the issue is dependent on other work. labels Aug 9, 2019
man0s added a commit to man0s/google-auth-library-java that referenced this issue Aug 9, 2019
@man0s
fix: Automatic-Module-Name to manifest (googleapis#324)
a785773
@man0s man0s mentioned this issue Aug 9, 2019
Merged
man0s added a commit to man0s/google-auth-library-java that referenced this issue Aug 9, 2019
@man0s
fix: Automatic-Module-Name to manifest (googleapis#324)
181e12a 
added changes
chingor13 pushed a commit that referenced this issue Aug 9, 2019
@man0s @chingor13
feat: add Automatic-Module-Name to manifest (#326)
29f58b4 
* fix: Automatic-Module-Name to manifest (#324)

* fix: Automatic-Module-Name to manifest (#324)

added changes

* fix: two space indents in /appengine/pom.xml

* fix: removed tabs
@chingor13
Copy link
Contributor

Fixed in #326

@elharo
Copy link
Contributor Author

elharo commented Aug 9, 2019

still need to add to google-auth-library-java/credentials/

@elharo elharo reopened this Aug 9, 2019
@elharo elharo closed this as completed Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
good first issue This issue is a good place to started contributing to this repository. help wanted We'd love to have community involvement on this issue. semver: patch A minor bug fix or small change. status: investigating The issue is under investigation, which is determined to be non-trivial.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add Automatic-Module-Name to manifest #324
2 participants
@chingor13 @elharo