Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drop six dependency #1452

Merged
merged 9 commits into from Jul 23, 2021
Merged

fix: drop six dependency #1452

merged 9 commits into from Jul 23, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jul 20, 2021

Fixes #1446 🦕

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2021
@parthea parthea marked this pull request as ready for review July 22, 2021 14:59
@parthea parthea requested review from a team as code owners July 22, 2021 14:59
@parthea parthea requested a review from busunkim96 July 22, 2021 14:59
@parthea parthea changed the title fix: drop six fix: drop dependency six Jul 22, 2021
@parthea parthea changed the title fix: drop dependency six fix: drop six dependency Jul 22, 2021
tseaver
tseaver suggested changes Jul 22, 2021
View reviewed changes
googleapiclient/discovery.py Outdated Show resolved Hide resolved
googleapiclient/discovery.py Outdated Show resolved Hide resolved
googleapiclient/http.py Show resolved Hide resolved
tests/test_discovery.py Outdated Show resolved Hide resolved
tests/test_discovery.py Outdated Show resolved Hide resolved
tests/test_discovery.py Outdated Show resolved Hide resolved
tests/test_discovery.py Outdated Show resolved Hide resolved
tests/test_discovery.py Outdated Show resolved Hide resolved
tests/test_discovery.py Outdated Show resolved Hide resolved
tests/test_discovery.py Outdated Show resolved Hide resolved
@parthea parthea added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Jul 23, 2021
@parthea
Copy link
Contributor Author

parthea commented Jul 23, 2021

@busunkim96 Please can you review/approve?

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Jul 23, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9f7b410 into master Jul 23, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the drop-six branch July 23, 2021 16:18
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 23, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 26, 2021
@release-please
chore: release 2.14.1 (#1456)
5875050 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.14.1](https://www.github.com/googleapis/google-api-python-client/compare/v2.14.0...v2.14.1) (2021-07-25)


### Bug Fixes

* drop six dependency ([#1452](https://www.github.com/googleapis/google-api-python-client/issues/1452)) ([9f7b410](https://www.github.com/googleapis/google-api-python-client/commit/9f7b4109b370e89c29db6c58c6bd2e09002c8d42))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@akrherz akrherz mentioned this pull request Oct 7, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees

@busunkim96 busunkim96

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove six dependency
3 participants
@parthea @tseaver @busunkim96