Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve issue where num_retries would have no effect #1244

Merged
merged 5 commits into from Mar 15, 2021
Merged

fix: Resolve issue where num_retries would have no effect #1244

merged 5 commits into from Mar 15, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Mar 9, 2021 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1243 馃

@parthea parthea requested a review from a team as a code owner March 9, 2021 14:34
@parthea parthea self-assigned this Mar 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 9, 2021
@parthea parthea mentioned this pull request Mar 9, 2021
Closed
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 9, 2021
@parthea parthea marked this pull request as draft March 9, 2021 14:40
@parthea parthea force-pushed the fix-regression-max-retries branch from 7643a2e to f41544a Compare March 9, 2021 14:51
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 15, 2021
@parthea parthea marked this pull request as ready for review March 15, 2021 15:35
@parthea parthea requested a review from busunkim96 March 15, 2021 16:04
@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Mar 15, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit c518472 into master Mar 15, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-regression-max-retries branch March 15, 2021 21:04
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 15, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 31, 2021
@release-please
chore: release 2.1.0 (#1256)
cc717a1 
馃 I have created a release \*beep\* \*boop\*
---
## [2.1.0](https://www.github.com/googleapis/google-api-python-client/compare/v2.0.2...v2.1.0) (2021-03-31)


### Features

* add status_code property on http error handling ([#1185](https://www.github.com/googleapis/google-api-python-client/issues/1185)) ([db2a766](https://www.github.com/googleapis/google-api-python-client/commit/db2a766bbd976742f6ef10d721d8423c8ac9246d))


### Bug Fixes

* Change default of `static_discovery` when `discoveryServiceUrl` set ([#1261](https://www.github.com/googleapis/google-api-python-client/issues/1261)) ([3b4f2e2](https://www.github.com/googleapis/google-api-python-client/commit/3b4f2e243709132b5ca41a3c23853d5067dfb0ab))
* correct api version in oauth-installed.md ([#1258](https://www.github.com/googleapis/google-api-python-client/issues/1258)) ([d1a255f](https://www.github.com/googleapis/google-api-python-client/commit/d1a255fcbeaa36f615cede720692fea2b9f894db))
* fix .close() ([#1231](https://www.github.com/googleapis/google-api-python-client/issues/1231)) ([a9583f7](https://www.github.com/googleapis/google-api-python-client/commit/a9583f712d13c67aa282d14cd30e00999b530d7c))
* Resolve issue where num_retries would have no effect ([#1244](https://www.github.com/googleapis/google-api-python-client/issues/1244)) ([c518472](https://www.github.com/googleapis/google-api-python-client/commit/c518472e836c32ba2ff5e8480ab5a7643f722d46))


### Documentation

* Distinguish between public/private docs in 2.0 guide ([#1226](https://www.github.com/googleapis/google-api-python-client/issues/1226)) ([a6f1706](https://www.github.com/googleapis/google-api-python-client/commit/a6f17066caf6e911b7e94e8feab52fa3af2def1b))
* Update README to promote cloud client libraries ([#1252](https://www.github.com/googleapis/google-api-python-client/issues/1252)) ([22807c9](https://www.github.com/googleapis/google-api-python-client/commit/22807c92ce754ff3d60f240ec5c38de50c5b654b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees

@parthea parthea

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in max_retries usage on GetSerialPortOutput()
2 participants
@parthea @busunkim96