Regression in max_retries usage on GetSerialPortOutput() #1243
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
type: docs
Improvement to the documentation for an API.
After
v2.0.2
,max_retries
is ignored inGetSerialPortOutput()
.This previously worked on
v1.12.8
.All our tests are failing since they used this feature of the python library.
I traced the problem to this commit:
#1116 and #1117
c6912836 - fix: handle error on service not enabled (#1117)
1117 changed the default reason to be
error.status
which isPERMISSION_DENIAD
instead usingerror.errors[0].reason
which israteLimitExceeded
and therefore later ignored in:Example for such json:
I think that correct fix for #1117 should not have changed the order of lookup - first check for
error.errors[0].reason
and if it doesn't exist fallback toerror.status
Sam
The text was updated successfully, but these errors were encountered: