Dependencies fail to resolve correctly when installing via egg #1179
Comments
|
Hi @bbatliner,
I didn't realize there wasn't an upper bound on google-auth on this library, and I would be fine with adding it for consistency. I would still recommend moving to a wheel though, since both
|
|
Thanks for the prompt reply! I opened #1180 to bound the dependency range. I concur moving to wheel is best and we're aware of the deprecation. Thanks for the info. |
busunkim96
added
priority: p2
For consistency with google-api-core, which specifies `google-auth >= 1.21.1, < 2.0dev` as a dependency. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/google-api-python-client/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #1179 🦕
Environment details
Python 3.8.5andPython 3.8.3pip 20.1.1andpip 19.3.1, respectively with the Python versionsgoogle-api-python-clientversion:1.12.8(latest)Steps to reproduce
wheelandsetuptoolsare installed.Build
FooModuleas an egg:python3 setup.py bdist_eggTry to install the egg:
python3 -m easy_install dist/FooModule-0.0.1-py3.8.eggORpython3 setup.py install. This should fail! The error iserror: google-auth 2.0.0.dev0 is installed but google-auth<2.0dev,>=1.21.1 is required by {'google-api-core'}See the full output below.Click to expand
pip3 freeze | xargs pip3 uninstall -yand verify onlypip,wheel, andsetuptoolsare installed before continuing.FooModuleas a wheel:python3 setup.py bdist_wheelpip3 install dist/FooModule-0.0.1-py3-none-any.whlThis will resolve the dependencies fine and succeed!What's going on?
This is my best guess. This package's dependencies are written as follows:
google-api-python-client/setup.py
Lines 34 to 41 in 91b61d3
Notably,
google-api-coreitself has a dependency ongoogle-auth,"google-auth >= 1.21.1, < 2.0dev".Naively, these dependencies specify incompatible ranges. If
google-auth>=1.16.0is installed first, then the resultinggoogle-authdependency ingoogle-api-corewill fail to be satisfied (google-auth 2.0.0.dev0 is installed but google-auth<2.0dev,>=1.21.1 is required by {'google-api-core'}).However, it seems like pip and/or the wheel format are able to figure this out, and install a compatible dependency. easy_install and/or the egg format are unable to figure this out, and an error occurs.
Is this something that the google-api-python-client team is interested in fixing? I think the fix would be as simple as removing the dependency on
google-auth, or upper-bounding the dependency range to matchgoogle-api-core's dependency range.Workarounds in the meantime
google-auth<2.0devtoFooModule. This is what we're doing today. It might rely on the ordering ofinstall_requires, which isn't guaranteed to be the installation order.FooModuleas a wheel. This is the more mature solution. We hope to do this eventually.The text was updated successfully, but these errors were encountered: