Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http.py refers to socket.error, which is deprecated #1148

Closed
dossett opened this issue Dec 23, 2020 · 1 comment · Fixed by #1161
Closed

http.py refers to socket.error, which is deprecated #1148

dossett opened this issue Dec 23, 2020 · 1 comment · Fixed by #1161
Assignees
@parthea
Labels
good first issue This issue is a good place to started contributing to this repository. type: cleanup An internal cleanup or hygiene concern.

Comments

@dossett
Copy link
Contributor

dossett commented Dec 23, 2020 •
edited

It should just use OSError
https://docs.python.org/3/library/socket.html#socket.error
@busunkim96 busunkim96 added the type: cleanup An internal cleanup or hygiene concern. label Dec 24, 2020
@parthea
Copy link
Contributor

parthea commented Dec 30, 2020

Hi @dossett, great find! Once #1147 is merged, it would be great to get your help with this one also!

@parthea parthea added the good first issue This issue is a good place to started contributing to this repository. label Dec 30, 2020
@googleapis googleapis deleted a comment Dec 30, 2020
@dossett dossett mentioned this issue Jan 13, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jan 13, 2021
@dossett
fix: replace deprecated socket.error with OSError (#1161)
b7b9986 
Fixes #1148 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
good first issue This issue is a good place to started contributing to this repository. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: replace deprecated socket.error with OSError dossett/google-api-python-client
3 participants
@parthea @dossett @busunkim96