Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Change error parsing to check for 'message' #1083

Merged
merged 4 commits into from Nov 8, 2020

Conversation

mm326
Copy link
Contributor

@mm326 mm326 commented Nov 7, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1082 🦕

@mm326 mm326 requested a review from a team as a code owner November 7, 2020 22:05
@google-cla
Copy link

google-cla bot commented Nov 7, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 7, 2020
@mm326
Copy link
Contributor Author

mm326 commented Nov 7, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 7, 2020
@mm326 mm326 changed the title Issue-1082: Change error parsing to check for 'message' docs: Change error parsing to check for 'message' Nov 7, 2020
@parthea parthea self-requested a review November 8, 2020 11:22
@parthea parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2020
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @mm326! Just minor observations regarding formatting, otherwise looks good!

googleapiclient/errors.py Outdated Show resolved Hide resolved
tests/test_errors.py Outdated Show resolved Hide resolved
tests/test_errors.py Outdated Show resolved Hide resolved
@parthea parthea added the semver: patch A minor bug fix or small change. label Nov 8, 2020
@mm326 mm326 requested a review from parthea November 8, 2020 13:31
@parthea parthea added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 8, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 8, 2020
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mm326 !

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Nov 8, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit a341c5a into googleapis:master Nov 8, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. semver: patch A minor bug fix or small change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add exception handling to docs
3 participants