New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update setup.py to install httplib2>=0.15.0 #1050
Conversation
@@ -38,7 +38,7 @@ | |||
# NOTE: Apache Beam tests depend on this library and cannot | |||
# currently upgrade their httplib2 version. | |||
# Please see https://github.com/googleapis/google-api-python-client/pull/841 | |||
"httplib2>=0.9.2,<1dev", | |||
"httplib2>=0.15.0,<1dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaltay Is it alright to bump this now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it can be bumped now. Beam has 'httplib2>=0.8,<0.18.0',
as the new range now. (https://github.com/apache/beam/blob/8bedfd402ccd1336f2b40fad58cd5833cecb9638/sdks/python/setup.py#L150)
Do you remember what was the specific problem?
(/cc @tvalentyn in case he remembers.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, no need to restrict this for Beam reasons anymore.
https://issues.apache.org/jira/browse/BEAM-9819 has some context for prior restrictions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@tomchop Could you delete the comments on 38-40 about httplib2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@busunkim96 Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tomchop!
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
I ran into the same issue described here: #1047
From that same issue: