Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with batch readme example #1002

Closed
fabtjar opened this issue Aug 12, 2020 · 2 comments · Fixed by #1003
Closed

Issues with batch readme example #1002

fabtjar opened this issue Aug 12, 2020 · 2 comments · Fixed by #1003
Assignees
@yoshi-automation
Labels
type: docs Improvement to the documentation for an API.

Comments

@fabtjar
Copy link

fabtjar commented Aug 12, 2020

On the batch readme there are examples on how to make a batch request:
https://github.com/googleapis/google-api-python-client/blob/master/docs/batch.md

One of the lines is: batch.execute(http=http)
I'm not sure where the http is coming from.
@busunkim96 busunkim96 mentioned this issue Aug 12, 2020
Merged
4 tasks
@busunkim96
Copy link
Contributor

HI @fabtjar, the http argument is optional. I've opened a PR to remove it.

@busunkim96 busunkim96 added the type: docs Improvement to the documentation for an API. label Aug 12, 2020
@fabtjar
Copy link
Author

fabtjar commented Aug 12, 2020

Cheers @busunkim96 👍

gcf-merge-on-green bot pushed a commit that referenced this issue Sep 1, 2020
@busunkim96
docs: remove http from batch execute docs (#1003)
5028fe7 
`http=http` is optional

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/google-api-python-client/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #1002  🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: remove http from batch execute docs googleapis/google-api-python-client
3 participants
@busunkim96 @fabtjar @yoshi-automation