From d5cf4e0b1537eeafdb96ae831bbdffc5f1c6a94c Mon Sep 17 00:00:00 2001 From: Cheskel Twersky Date: Thu, 2 Sep 2021 12:06:09 +0300 Subject: [PATCH] fix: remove repeated calls to self._get_reason (#1513) self._get_reason is being called in \_\_init\_\_ (https://github.com/googleapis/google-api-python-client/pull/1185) , so why not save it then? also in the \_\_repr\_\_ function we got the reason by calling the _get_reason function right in the beginning, but was then called again. --- googleapiclient/errors.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/googleapiclient/errors.py b/googleapiclient/errors.py index 332327ec04f..385558c4897 100644 --- a/googleapiclient/errors.py +++ b/googleapiclient/errors.py @@ -43,7 +43,7 @@ def __init__(self, resp, content, uri=None): self.content = content self.uri = uri self.error_details = "" - self._get_reason() + self.reason = self._get_reason() @property def status_code(self): @@ -75,25 +75,24 @@ def _get_reason(self): pass if reason is None: reason = "" - return reason + return reason.strip() def __repr__(self): - reason = self._get_reason() if self.error_details: return '' % ( self.resp.status, self.uri, - reason.strip(), + self.reason, self.error_details, ) elif self.uri: return '' % ( self.resp.status, self.uri, - self._get_reason().strip(), + self.reason, ) else: - return '' % (self.resp.status, self._get_reason()) + return '' % (self.resp.status, self.reason) __str__ = __repr__