fix!: stop ignoring YouTube, and re-generate with latest API #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
JustinBeckwith
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2575 +/- ##
==========================================
+ Coverage 82.75% 82.84% +0.08%
==========================================
Files 11 11
Lines 1856 1854 -2
Branches 123 123
==========================================
Hits 1536 1536
+ Misses 320 318 -2
Continue to review full report at Codecov.
|
bcoe
approved these changes
Mar 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2574.
During the great OnePlatform migration of 2020, at some point the YouTube discovery bindings got very, very broken. To unblock the pipeline, I started ignoring changes in the discovery file, and just kept on shipping the old client. This PR turns generation for YouTube back on, and gives the API it's first update in a long time. I can only assume there are some breaking changes in here.