Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade webpack from 4 to 5 #2524

Merged
merged 2 commits into from Feb 18, 2021
Merged

fix: upgrade webpack from 4 to 5 #2524

merged 2 commits into from Feb 18, 2021

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Feb 18, 2021 •
edited

Replaces #2480

@sofisl sofisl requested a review from a team as a code owner February 18, 2021 00:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 18, 2021
@codecov
Copy link

codecov bot commented Feb 18, 2021 •
edited

Codecov Report

Merging #2524 (03b28f0) into master (a9e872a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2524   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files          11       11           
  Lines        1756     1756           
  Branches      103      103           
=======================================
  Hits         1500     1500           
  Misses        256      256

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9e872a...d7ac822. Read the comment docs.

@sofisl sofisl changed the title New webpack attempt fix: upgrade webpack from 4 to 5 Feb 18, 2021
@sofisl sofisl requested a review from bcoe February 18, 2021 00:12
@sofisl sofisl mentioned this pull request Feb 18, 2021
Closed
@bcoe bcoe merged commit ecfd8bf into master Feb 18, 2021
@bcoe bcoe deleted the newWebpackAttempt branch February 18, 2021 17:21
This was referenced Mar 16, 2021
Closed
Open
@sofisl sofisl mentioned this pull request Jun 1, 2021
Closed
@sofisl sofisl mentioned this pull request Aug 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sofisl @bcoe