feat(actions): switch to GitHub action for releases #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #2458 +/- ##
=======================================
Coverage 85.43% 85.43%
=======================================
Files 11 11
Lines 1723 1723
Branches 99 99
=======================================
Hits 1472 1472
Misses 251 251 Continue to review full report at Codecov.
|
bcoe
commented
Dec 1, 2020
.github/workflows/release.yaml
Outdated
| const latestRelease = await github.issues.addLabels({ | ||
| owner, | ||
| repo, | ||
| issue_number: ${{steps.release-please.outputs.pr}}, |
There was a problem hiding this comment.
Is the step called release-pr, not release-please?
There was a problem hiding this comment.
(I have no idea actually :) )
There was a problem hiding this comment.
No, good catch, I believe it should be release-pr.
bcoe
commented
Dec 1, 2020
alexander-fenster
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves us to using a GitHub action for running release-please and publishing to npm, this will make it easier for us to have two release flows in the repo:
googleapis.src/apis.TODO: