test: ensure params are not deleted from global options #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
bcoe
approved these changes
May 28, 2020
bcoe
reviewed
Jun 2, 2020
test/test.options.ts
Outdated
| @@ -99,17 +99,19 @@ describe('Options', () => { | |||
| }); | |||
|
|
|||
| it('should use the same per-API setting twice', async () => { | |||
There was a problem hiding this comment.
Can you think of any edge cases we might be missing a test for, e.g., we're happy with our tests for per-request options.
There was a problem hiding this comment.
I think we're in pretty ok shape here. You can always have more tests, but we test a pretty broad range.
JustinBeckwith
force-pushed
the
dododouble
branch
from
dca2aa2
to
315b3fc
Compare
Codecov Report
@@ Coverage Diff @@
## master #2190 +/- ##
==========================================
- Coverage 84.14% 84.08% -0.07%
==========================================
Files 9 9
Lines 1602 1602
Branches 114 131 +17
==========================================
- Hits 1348 1347 -1
- Misses 254 255 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is expected to fail at this moment because of #2029. When the change in googleapis/nodejs-googleapis-common#285 lands, and a new version of the module ships, this should start to pass 馃槑