Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: run the generator #1935

Merged
merged 1 commit into from Jan 16, 2020
Merged

feat!: run the generator #1935

merged 1 commit into from Jan 16, 2020

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2020
@JustinBeckwith JustinBeckwith requested review from bcoe and a team January 15, 2020 21:10
@bcoe bcoe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 15, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 15, 2020
@bcoe
Copy link
Contributor

bcoe commented Jan 15, 2020

I don't think we should land #1905, until we figure out why this broke so many tests.

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like this broke a bunch of thing; won't have cycles to dig into it until Friday I don't think.

@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #1935 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1935      +/-   ##
==========================================
+ Coverage    40.5%   40.68%   +0.17%     
==========================================
  Files           5        5              
  Lines         995      998       +3     
  Branches        7        7              
==========================================
+ Hits          403      406       +3     
  Misses        592      592
Impacted Files Coverage Δ
src/index.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 629fa69...d235895. Read the comment docs.

@bcoe bcoe merged commit e5d8c08 into master Jan 16, 2020
@bcoe bcoe deleted the gen444 branch January 16, 2020 00:08
@release-please release-please bot mentioned this pull request Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants