Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change JSDoc from .resource to .requestBody #1864

Merged
merged 3 commits into from Nov 6, 2019

Conversation

sarunint
Copy link
Contributor

We moved from .resource to .requestBody since v30, we should
also change the JSDoc too.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1863

We moved from `.resource` to `.requestBody` since v30, we should
also change the JSDoc too.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 21, 2019
@bcoe
Copy link
Contributor

bcoe commented Oct 22, 2019

@sarunint thank you for the patch, will make an effort to review as soon as possible.

@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 6, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 6, 2019
@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #1864 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1864   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files           2        2           
  Lines         437      437           
  Branches        7        7           
=======================================
  Hits          422      422           
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd9bfdc...c1b48e9. Read the comment docs.

@bcoe bcoe merged commit 8803e77 into googleapis:master Nov 6, 2019
@bcoe
Copy link
Contributor

bcoe commented Nov 6, 2019

@sarunint thank you for the contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSDoc still indicates .resource instead of .requestBody
5 participants