Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(auth)!: pulling in updated idempotent google-auth-library #1769

Merged
merged 7 commits into from Jul 29, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jul 24, 2019

BREAKING CHANGE: pulls in breaking changes to google-auth-library that removes options from getClient(); a transitional API has been introduced in googleapis-common that provides a shim for getClient() with parameters, but should have less side effects.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2019
@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #1769 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1769      +/-   ##
==========================================
- Coverage   96.52%   96.47%   -0.06%     
==========================================
  Files           2        2              
  Lines         432      425       -7     
  Branches        7        7              
==========================================
- Hits          417      410       -7     
  Misses         15       15
Impacted Files Coverage Δ
src/googleapis.ts 89.28% <100%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86074f3...40b91ea. Read the comment docs.

@bcoe bcoe changed the title WIP refactor(auth)!: pulling in updated idempotent google-auth-library refactor(auth)!: pulling in updated idempotent google-auth-library Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants