fix: don't replace '.' with '_' in interface #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
bcoe
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
JustinBeckwith
approved these changes
Jul 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #1757 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 2 2
Lines 432 432
Branches 7 7
=======================================
Hits 417 417
Misses 15 15Continue to review full report at Codecov.
|
jkwlui
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1736
I believe we should not be replacing
.with_for the interfaces we generate, as the discovery api expects2.1not2_1.aside, I tried running the generator, but it seems to have some oddities; I might need some help regenerating the libraries if we land this.