Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make webpack work on Windows #1742

Merged
merged 2 commits into from Jun 27, 2019
Merged

fix: make webpack work on Windows #1742

merged 2 commits into from Jun 27, 2019

Conversation

alexander-fenster
Copy link
Member

Turns out webpack rules break on Windows because of different path separator used. This PR fixes #1732 by fixing the regular expression in the null-module rules in webpack.config.js to accept both / and \ as a possible path separators.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2019
@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 19, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 19, 2019
@alexander-fenster
Copy link
Member Author

@JustinBeckwith @bcoe The CI fails for some totally unrelated reason:

  1) Clients
       should include default params when only callback is provided to API call:
     FetchError: request to https://datastore.googleapis.com/v1/projects/test-project-id:lookup?projectId=test-project-id&myParam=123 failed, reason: Nock: No match for request {
  "method": "POST",
  "url": "https://datastore.googleapis.com/v1/projects/test-project-id:lookup?projectId=test-project-id&myParam=123",
  "headers": {
    "accept-encoding": [
      "gzip"
    ],
    "user-agent": [
      "google-api-nodejs-client/2.0.2 (gzip)"
    ],
    "accept": [
      "application/json"
    ],
    "content-length": [
      "0"
    ],
    "connection": [
      "close"
    ]
  }
}
      at OverriddenClientRequest.<anonymous> (node_modules/node-fetch/lib/index.js:1455:11)
      at /tmpfs/src/github/google-api-nodejs-client/node_modules/nock/lib/request_overrider.js:221:11
      at process._tickCallback (internal/process/next_tick.js:61:11)

Do you have an idea what's going on? It obviously cannot be related to my webpack config change in this PR.

@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 25, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 25, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 25, 2019
@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #1742 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1742   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files           2        2           
  Lines         428      428           
  Branches        7        7           
=======================================
  Hits          413      413           
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799e391...8be8fa8. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit cac269f into master Jun 27, 2019
@JustinBeckwith JustinBeckwith deleted the webpack-windows branch December 13, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modules "net" and "tls" not found when running webpack under sheets API directory
5 participants