Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: run the generator #1709

Merged
merged 2 commits into from May 13, 2019
Merged

feat!: run the generator #1709

merged 2 commits into from May 13, 2019

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented May 13, 2019

BREAKING CHANGE: This release has a few breaking changes.

  • Node.js 8.x is now the minimum required version
  • The healthcare/v1alpha API has been removed

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 13, 2019
@JustinBeckwith JustinBeckwith changed the title feat: run the generator feat!: run the generator May 13, 2019
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; although this is very much a rubber stamp.

"nock": "^10.0.6",
"nunjucks": "^3.2.0",
"nyc": "^14.1.1",
"open": "^6.3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why we moved from opn to open.

"google-auth-library": "^3.0.0",
"googleapis-common": "^0.7.0"
"google-auth-library": "^4.0.0",
"googleapis-common": "^2.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the the most important bit right?

@@ -29,7 +29,7 @@
"webpack": "webpack"
},
"dependencies": {
"googleapis-common": "^0.7.0"
"googleapis-common": "^2.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good to see this picked up in each package.

@JustinBeckwith JustinBeckwith merged commit 6817c39 into master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants