feat: type all the things #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinBeckwith
requested review from
ofrobots,
jmdobry,
alexander-fenster and
a team
googlebot
added
the
cla: yes
| @@ -35,7 +35,7 @@ describe('GoogleApis#discover', () => { | |||
| localApis.splice(localApis.indexOf('index.js.map'), 1); | |||
|
|
|||
| localApis.forEach((name) => { | |||
| assert(g2[name]); | |||
| assert(g2[name], `API '${name}' is not available on GoogleApis`); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
alexander-fenster
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is a doozy. This dramatically changes the way the generator works, but in a way that is backward compatible. We're now generating es6 classes and interfaces for all of the APIs. This paves the way for promise support, better d.ts support, and better documentation.
As a bonus, resolves #881