Skip to content

Commit

Permalink
fix(deps): pin TypeScript below 3.7.0 (#1897)
Browse files Browse the repository at this point in the history
  • Loading branch information
bcoe committed Dec 6, 2019
1 parent a3e9285 commit 5cdc823
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 8 deletions.
6 changes: 3 additions & 3 deletions package.json
@@ -1,8 +1,8 @@
{
"license": "Apache-2.0",
"dependencies": {
"google-auth-library": "^5.2.0",
"googleapis-common": "^3.1.0"
"google-auth-library": "^5.6.1",
"googleapis-common": "^3.2.0"
},
"files": [
"build/src",
Expand Down Expand Up @@ -88,6 +88,6 @@
"server-destroy": "^1.0.1",
"source-map-support": "^0.5.12",
"tmp": "^0.1.0",
"typescript": "~3.7.0"
"typescript": "3.6.4"
}
}
3 changes: 2 additions & 1 deletion renovate.json
Expand Up @@ -14,5 +14,6 @@
"extends": "packages:linters",
"groupName": "linters"
}
]
],
"ignoreDeps": ["typescript"]
}
3 changes: 2 additions & 1 deletion src/generator/docs.ts
Expand Up @@ -15,9 +15,10 @@
import * as execa from 'execa';
import * as fs from 'fs';
import * as nunjucks from 'nunjucks';
import Q from 'p-queue';
import * as path from 'path';
import {promisify} from 'util';
// there is a typings issue with p-queue and TypeScript 3.6.4.
const {default: Q} = require('p-queue');

const readdir = promisify(fs.readdir);
const writeFile = promisify(fs.writeFile);
Expand Down
7 changes: 4 additions & 3 deletions src/generator/generator.ts
Expand Up @@ -25,10 +25,11 @@ import {
} from 'googleapis-common';
import * as mkdirp from 'mkdirp';
import * as nunjucks from 'nunjucks';
import Q from 'p-queue';
import * as path from 'path';
import * as url from 'url';
import * as util from 'util';
// there is a typings issue with p-queue and TypeScript 3.6.4.
const {default: Q} = require('p-queue');

const writeFile = util.promisify(fs.writeFile);
const readDir = util.promisify(fs.readdir);
Expand Down Expand Up @@ -236,7 +237,7 @@ export class Generator {
const queue = new Q({concurrency: 10});
console.log(`Generating ${apis.length} APIs...`);
queue.addAll(
apis.map(api => {
apis.map((api: {[key: string]: string}) => {
return async () => {
this.log('Generating API for %s...', api.id);
this.logResult(
Expand Down Expand Up @@ -365,7 +366,7 @@ export class Generator {
fragment = fragment.replace(/`\*/gi, '`<');
fragment = fragment.replace(/\*`/gi, '>`');
const lines = fragment.split('\n');
lines.forEach((line, i) => {
lines.forEach((line: string, i: number) => {
lines[i] = '*' + (line ? ' ' + lines[i] : '');
});
fragment = lines.join('\n');
Expand Down

0 comments on commit 5cdc823

Please sign in to comment.