Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grab version from package metadata #1419

Merged
merged 3 commits into from Nov 14, 2019

Conversation

chingor13
Copy link
Collaborator

This PR allows the GoogleUtils to inspect its own version at start time. If it's running from a package, it can fetch the version from the package manifest's implementation version. If it's not, it can read it from a properties file created at compile time to read the version.

Note:

  • This is similar to how gax inspects its own version for the x-goog-api-client header.
  • We needed to update the checkstyle plugin to make this pass

@chingor13 chingor13 requested a review from a team as a code owner November 13, 2019 23:18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 13, 2019
@chingor13 chingor13 merged commit a6c6dec into googleapis:master Nov 14, 2019
@chingor13 chingor13 deleted the detect-version branch November 14, 2019 00:07
BenWhitehead added a commit to googleapis/java-storage that referenced this pull request Aug 17, 2023
Update StorageOptions to resolve their version from maven metadata rather than manifest version. A jar can only have on MANIFEST.mf thereby leading to storage thinking it is a version it is not.

In particular, if a program is shaded, this change will now allow for the actual version of storage to be carried through.

Related googleapis/google-api-java-client#1419
BenWhitehead added a commit to googleapis/java-storage that referenced this pull request Aug 23, 2023
Update StorageOptions to resolve their version from maven metadata rather than manifest version. A jar can only have on MANIFEST.mf thereby leading to storage thinking it is a version it is not.

In particular, if a program is shaded, this change will now allow for the actual version of storage to be carried through.

Related googleapis/google-api-java-client#1419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants