Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compute): make MetadataItems.Value a pointer #973

Merged
merged 1 commit into from Apr 7, 2021
Merged

fix(compute): make MetadataItems.Value a pointer #973

merged 1 commit into from Apr 7, 2021

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Apr 7, 2021

This is already the case in both the beta and v1 surface.

This is already the case in both the beta and v1 surface.
@codyoss codyoss requested review from yoshi-approver and a team as code owners April 7, 2021 14:57
@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label Apr 7, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 7, 2021
@codyoss codyoss requested a review from tbpg April 7, 2021 14:57
@codyoss
Copy link
Member Author

codyoss commented Apr 7, 2021

cc @illfelder

@illfelder
Copy link

Thank you for making this update - it looks good to me!

Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for consistency with other versions -- essentially a bug at this point.

@codyoss codyoss merged commit d8cce34 into googleapis:master Apr 7, 2021
@codyoss codyoss deleted the compute-alpha-fix branch April 7, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants