Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(internal): don't self-sign JWT when an endpoint provided #847

Merged
merged 1 commit into from Jan 29, 2021
Merged

fix(internal): don't self-sign JWT when an endpoint provided #847

merged 1 commit into from Jan 29, 2021

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Jan 29, 2021 •
edited

This was recently caught by the spanner team. This is a part of the spec.

@codyoss codyoss requested review from bshaffer and tbpg January 29, 2021 16:15
@codyoss codyoss requested review from yoshi-approver and a team as code owners January 29, 2021 16:15
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 29, 2021
@codyoss
Copy link
Member Author

codyoss commented Jan 29, 2021

cc @olavloite

@codyoss codyoss merged commit 55f262c into googleapis:master Jan 29, 2021
@codyoss codyoss deleted the jwt-fix branch January 29, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

@tbpg tbpg tbpg approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codyoss @bshaffer @tbpg