Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transport/bytestream: TestClientWrite_CloseAndRecvFails is flaky #775

Closed
codyoss opened this issue Dec 7, 2020 · 0 comments · Fixed by #787
Closed

transport/bytestream: TestClientWrite_CloseAndRecvFails is flaky #775

codyoss opened this issue Dec 7, 2020 · 0 comments · Fixed by #787
Assignees
@codyoss
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@codyoss
Copy link
Member

codyoss commented Dec 7, 2020

Fix this test.
@codyoss codyoss changed the title transport/bytstream: TestClientWrite_CloseAndRecvFails is flaky transport/bytestream: TestClientWrite_CloseAndRecvFails is flaky Dec 7, 2020
@codyoss codyoss self-assigned this Dec 7, 2020
@codyoss codyoss added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 7, 2020
@codyoss codyoss mentioned this issue Dec 11, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jan 11, 2021
@codyoss
feat(transport/bytestream): Add Close method for shutdown (#787)
96bfd87 
This pacakge is still labeled expirmental. At some point we should
decide if we want to keep supporting it or deprecate and remove.

Fixes: #775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyoss codyoss

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(transport/bytestream): Add Close method for shutdown
1 participant
@codyoss