Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compute): don't tigger linter for field named Deprecated #774

Merged
merged 3 commits into from Dec 8, 2020
Merged

fix(compute): don't tigger linter for field named Deprecated #774

merged 3 commits into from Dec 8, 2020

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Dec 7, 2020

Fixes: #767

@codyoss codyoss requested a review from a team as a code owner December 7, 2020 17:27
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2020
@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label Dec 7, 2020
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Dec 7, 2020
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 8, 2020
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Dec 8, 2020
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 8, 2020
@codyoss codyoss merged commit d2bc921 into googleapis:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbpg tbpg tbpg approved these changes

Assignees
No one assigned
Labels
api: compute Issues related to the Compute Engine API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

image: image.Deprecated is deprecated: The deprecation status associated with this image
2 participants
@codyoss @tbpg