Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded guard condition after GAPIC generator rollout of WithDefaultEndpointTemplate #2359

Open
quartzmo opened this issue Jan 18, 2024 · 0 comments
Open

Remove unneeded guard condition after GAPIC generator rollout of WithDefaultEndpointTemplate #2359

quartzmo opened this issue Jan 18, 2024 · 0 comments
Assignees
@quartzmo
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@quartzmo
Copy link
Member

Once the GAPIC generator rollout of WithDefaultEndpointTemplate is complete, remove the following guard condition from around internal/cba.go#L79:

&& settings.DefaultEndpointTemplate != ""

And uncomment the error check just below:

// if settings.DefaultEndpointTemplate == "" {
// 	return nil, "", errors.New("internaloption.WithDefaultEndpointTemplate is required if option.WithUniverseDomain is not googleapis.com")
// }
@quartzmo quartzmo added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jan 18, 2024
@quartzmo quartzmo self-assigned this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quartzmo quartzmo

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@quartzmo