fix(internal/gensupport): Make SendRequestWithRetry check for canceled contexts twice #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes it deterministic to call SendRequestWithRetry with a canceled context. This is going to be useful because some Cloud APIs rely on the context being canceled to prevent some operations from proceeding, like [`storage.(*ObjectHandle).NewWriter`](https://pkg.go.dev/cloud.google.com/go/storage#ObjectHandle.NewWriter). Fixes: googleapis#1358
codyoss
requested changes
Dec 21, 2021
codyoss
changed the title
codyoss
changed the title
tritone
approved these changes
Dec 21, 2021
tritone
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
The presubmit is failing but if you run |
Unsure why `go get` didn't to it by itself :/
tidied up! |
tritone
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
tritone
added a commit
to tritone/google-api-go-client
that referenced
this pull request
Dec 22, 2021
The select statement is non-deterministic, so currently, if the pause is completed and ALSO the context has been canceled or timeout elapsed, a request may still occur. This PR prevents that circumstance from occurring. Also removed something in a test that seems to be a workaround for the race condition. Inspired by googleapis#1359 & googleapis#1358.
tritone
added a commit
that referenced
this pull request
Jan 6, 2022
The select statement is non-deterministic, so currently, if the pause is completed and ALSO the context has been canceled or timeout elapsed, a request may still occur. This PR prevents that circumstance from occurring. Also removed something in a test that seems to be a workaround for the race condition. Inspired by #1359 & #1358.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it deterministic to call SendRequestWithRetry with a
canceled context. This is going to be useful because some Cloud APIs
rely on the context being canceled to prevent some operations from
proceeding, like
storage.(*ObjectHandle).NewWriter.Fixes: #1358