Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(impersonate): allow lifetimes up to 12 hours #1186

Merged
merged 3 commits into from Aug 30, 2021
Merged

fix(impersonate): allow lifetimes up to 12 hours #1186

merged 3 commits into from Aug 30, 2021

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Aug 26, 2021

Service accounts that have been added to an org policy
with constraints/iam.allowServiceAccountCredentialLifetimeExtension may
request a token lifetime of up to 12 hours.

Fixes: #1185

@codyoss codyoss requested review from yoshi-approver and a team as code owners August 26, 2021 02:44
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2021
@codyoss
Copy link
Member Author

codyoss commented Aug 26, 2021

cc @salrashid123

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Aug 26, 2021
Service accounts that have been added to an org policy
with constraints/iam.allowServiceAccountCredentialLifetimeExtension may
request a token lifetime of up to 12 hours.

Fixes: #1185
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 26, 2021
@codyoss codyoss requested a review from noahdietz August 30, 2021 22:25
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Aug 30, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 569c56b into googleapis:master Aug 30, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 30, 2021
@codyoss codyoss deleted the imp-lifetime branch August 31, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

impersonate: token limited to 1 hour
2 participants