Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(option): add internaloption to force use of certain credential #1162

Merged
merged 10 commits into from Aug 31, 2021

Conversation

BrennaEpp
Copy link
Contributor

A new internaloption added that forces the client to use a certain credential. This ensures that if a user directly passes in their own credentials, we can capture and use these credentials.

This is part of the effort to improve Signed URLs in the Go Storage Client.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2021
@BrennaEpp BrennaEpp marked this pull request as ready for review August 17, 2021 21:39
@BrennaEpp BrennaEpp requested review from yoshi-approver and a team as code owners August 17, 2021 21:39
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally seems fine to me-- @codyoss @broady thoughts?

option/internaloption/internaloption.go Outdated Show resolved Hide resolved
@codyoss
Copy link
Member

codyoss commented Aug 20, 2021

LGTM, but I worked on this code so I will let @broady review.

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Aug 31, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 62f4bc9 into googleapis:master Aug 31, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants