feat(internaloption): add AllowNonDefaultServiceAccount internaloption #1127
Conversation
google-cla
bot
added
the
cla: yes
|
@mohanli-ml Is there an AIP or design doc for this? I lack the context for this change. |
|
@mohanli-ml Following up on Cody's comment... Is this something we can enable across all APIs? Why do we need an option for it? |
|
Sorry for the late response. This option is proposed to solve the conflict that DirectPath only support the default service account, while currently in GCP non-default service account is largely used. We:
This option should not be enabled before the service owners talk to the MDB group directpath-security-reviews and get their approval. See details in https://docs.google.com/document/d/1DgKCBcmz3J0OjbpO0BZBrwQIm3LrDBs8t9AS67NG0z4/edit#heading=h.qkiqy0p84mi8. |
| @@ -138,7 +138,7 @@ func dial(ctx context.Context, insecure bool, o *internal.DialSettings) (*grpc.C | |||
| // * The endpoint is a host:port (or dns:///host:port). | |||
| // * Credentials are obtained via GCE metadata server, using the default | |||
| // service account. | |||
| if o.EnableDirectPath && checkDirectPathEndPoint(endpoint) && isTokenSourceDirectPathCompatible(creds.TokenSource) && metadata.OnGCE() { | |||
| if o.EnableDirectPath && checkDirectPathEndPoint(endpoint) && isTokenSourceDirectPathCompatible(creds.TokenSource, o) && metadata.OnGCE() { | |||
There was a problem hiding this comment.
&& (o.AllowNonDefaultServiceAccount || isTokenSourceDirectPathCompatible(creds.TokenSource))
There was a problem hiding this comment.
Sorry it seems this comment will change the functionality. For example if creds.TokenSource is nil, then isTokenSourceDirectPathCompatible(creds.TokenSource, o) will be false, but (o.AllowNonDefaultServiceAccount || isTokenSourceDirectPathCompatible(creds.TokenSource)) could be true if o.AllowNonDefaultServiceAccount is true.
|
LGTM, just a nit |
broady
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Add an internal option AllowNonDefaultServiceAccount for cloud services to bypass the check that credential must be retrieved from the metadata server and must use the default service account. In this way, non-default service account can be used for DirectPath.