Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transport): Perform mtls endpoint switching with custom http client #1038

Merged
merged 1 commit into from May 24, 2021

Conversation

shinfan
Copy link
Contributor

@shinfan shinfan commented May 24, 2021

The terraform CLI requires this change in order to support mTLS.

For existing users that provide custom http clients today, this change is invisible since it is gated by the mTLS environment variable.

@shinfan shinfan requested review from yoshi-approver and a team as code owners May 24, 2021 20:00
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 24, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyoss codyoss changed the title transport: Perform mtls endpoint switching with custom http client fix(transport): Perform mtls endpoint switching with custom http client May 24, 2021
@codyoss codyoss merged commit c07165f into googleapis:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants