Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transport): increase ReadIdleTimeout #1028

Merged
merged 1 commit into from May 18, 2021
Merged

fix(transport): increase ReadIdleTimeout #1028

merged 1 commit into from May 18, 2021

Conversation

tritone
Copy link
Contributor

@tritone tritone commented May 18, 2021

Increase this value to comply with CFE rate limit on pings.

Closes googleapis/google-cloud-go#4121

@tritone
fix(transport): increase ReadIdleTimeout
d31977e 
Increase this value to comply with CFE rate limit on pings.

Closes googleapis/google-cloud-go#4121
@tritone tritone requested review from yoshi-approver and a team as code owners May 18, 2021 22:53
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2021
@tritone tritone requested a review from shollyman May 18, 2021 22:54
shollyman
shollyman approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer on LGTM: I don't claim to have full awareness of the magic here, but that seems like a more sensible default generally.

codyoss
codyoss approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyoss codyoss merged commit b3cd013 into googleapis:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@codyoss codyoss codyoss approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bigquery: TestIntegration_InsertAndReadStructs failed
3 participants
@tritone @shollyman @codyoss