Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: drops Node 8 from engines field #315

Merged
merged 2 commits into from Mar 19, 2020
Merged

feat!: drops Node 8 from engines field #315

merged 2 commits into from Mar 19, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Mar 19, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2020
xiaozhenliu-gg5
xiaozhenliu-gg5 approved these changes Mar 19, 2020
View reviewed changes
Copy link

@xiaozhenliu-gg5 xiaozhenliu-gg5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@codecov
Copy link

codecov bot commented Mar 19, 2020 •
edited

Codecov Report

Merging #315 into master will decrease coverage by 1.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
- Coverage   97.89%   96.21%   -1.69%     
==========================================
  Files           1        1              
  Lines         238      238              
  Branches       48       41       -7     
==========================================
- Hits          233      229       -4     
- Misses          5        9       +4
Impacted Files Coverage Δ
src/index.ts 96.21% <0%> (-1.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dead57e...0d6bd15. Read the comment docs.

@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 19, 2020
@bcoe bcoe merged commit acb6233 into master Mar 19, 2020
@bcoe bcoe deleted the drop-node-8 branch March 19, 2020 19:07
@release-please release-please bot mentioned this pull request Mar 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaozhenliu-gg5 xiaozhenliu-gg5 xiaozhenliu-gg5 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcoe @xiaozhenliu-gg5 @googlebot @yoshi-kokoro