fix: properly bundle requests with snake_case #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #921 +/- ##
==========================================
- Coverage 88.46% 88.42% -0.05%
==========================================
Files 41 41
Lines 6555 6583 +28
Branches 523 525 +2
==========================================
+ Hits 5799 5821 +22
- Misses 752 758 +6
Partials 4 4
Continue to review full report at Codecov.
|
bcoe
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/nodejs-logging#909. In the bundling configuration the
log_namefield is in snake_case, while the request object haslogNamein camelCase, so it's not used in the bundle ID computation. Fixing this by converting all field names to camelCase, it happens once inBundleDescriptorconstructor so does not affect runtime in any way.