fix: fix match logic for path template #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
===========================================
+ Coverage 59.68% 88.96% +29.28%
===========================================
Files 46 38 -8
Lines 7426 6344 -1082
Branches 107 508 +401
===========================================
+ Hits 4432 5644 +1212
+ Misses 2994 697 -2297
- Partials 0 3 +3
Continue to review full report at Codecov.
|
xiaozhenliu-gg5
requested review from
alexander-fenster,
JustinBeckwith,
summer-ji-eng and
bcoe
src/pathTemplate.ts
Outdated
| @@ -35,6 +35,8 @@ export class PathTemplate { | |||
| constructor(data: string) { | |||
| this.data = data; | |||
| this.segments = this.parsePathTemplate(data); | |||
| console.warn('this.bindings: ', this.bindings); | |||
There was a problem hiding this comment.
Please remove the logging output
There was a problem hiding this comment.
Thanks! done.
alexander-fenster
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
failing case: match
projects/{project=*}withproject: long-project-namefrom dialogflow sample-testgoogleapis/nodejs-dialogflow#617
the original logic is to check the matching string (
long-project-name) if it can be divided by-_.~, to decide whether it's non-slash resource (for example match{user_a}-{user_b}withusera-userb). but it will fail for the above case.Now we check the segments
{project=*}if it has multiple brackets, it will be taken as non-slash resource (for example{user_a}-{user_b}