Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clientConfig can be omitted #617

Merged
merged 1 commit into from Oct 9, 2019
Merged

Conversation

alexander-fenster
Copy link
Member

We don't really need to force users to pass clientConfig in the options, undefined works just fine.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 9, 2019
@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #617 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #617      +/-   ##
=========================================
- Coverage   88.42%   88.4%   -0.03%     
=========================================
  Files          65      65              
  Lines        4129    4130       +1     
  Branches      319     320       +1     
=========================================
  Hits         3651    3651              
- Misses        386     387       +1     
  Partials       92      92
Impacted Files Coverage Δ
src/operationsClient.ts 17.14% <0%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062b0a9...4a05bfc. Read the comment docs.

@alexander-fenster alexander-fenster merged commit b4d7e8c into master Oct 9, 2019
@alexander-fenster alexander-fenster deleted the client-config branch October 9, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants