Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streaming: forwards metadata and status failed #1422

Closed
flaky-bot bot opened this issue Feb 3, 2023 · 2 comments
Closed

streaming: forwards metadata and status failed #1422

flaky-bot bot opened this issue Feb 3, 2023 · 2 comments
Assignees
Labels
flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Feb 3, 2023

Note: #1390 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: f6ee114
buildURL: Build Status, Sponge
status: failed

Test output
Expected values to be strictly deep-equal:
+ actual - expected

{
code: 200,
details: '',
message: 'OK',

  • metadata: {

  • metadata: true
    
  • }
    }

    • expected - actual

    {
    "code": 200
    "details": ""
    "message": "OK"

    • "metadata": {
    • "metadata": true
    • }
      }

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:

  • actual - expected

    {
    code: 200,
    details: '',
    message: 'OK',

  • metadata: {
  • metadata: true
    
  • }
    }
    at check (build/test/unit/streaming.js:197:24)
    -> /workspace/test/unit/streaming.ts:238:16
    at StreamProxy. (build/test/unit/streaming.js:205:13)
    -> /workspace/test/unit/streaming.ts:247:7
    at Timeout._onTimeout (build/test/unit/streaming.js:175:19)
    -> /workspace/test/unit/streaming.ts:211:11
    at listOnTimeout (internal/timers.js:554:17)
    at processTimers (internal/timers.js:497:7)
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 3, 2023
@alexander-fenster alexander-fenster self-assigned this Feb 3, 2023
@alexander-fenster alexander-fenster added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Feb 3, 2023
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Feb 4, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Feb 4, 2023

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (f6ee114), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@leahecole
Copy link
Contributor

Closing as obsolete, my flaky bot friend will reopen if it's still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants