This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
feat: add batch throttled time to tracer #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
| @@ -93,6 +95,7 @@ | |||
| private SettableApiFuture<Void> closeFuture; | |||
| private final BatcherStats batcherStats = new BatcherStats(); | |||
| private final FlowController flowController; | |||
| private ApiCallContext callContext; | |||
There was a problem hiding this comment.
this should be final
| if (callContext != null) { | ||
| callContext = | ||
| callContext.withOption(THROTTLED_TIME_KEY, accumulatedBatch.totalThrottledTimeMs); | ||
| unaryCallable.withDefaultCallContext(callContext); |
There was a problem hiding this comment.
I think this is a typo
igorbernstein2
approved these changes
Oct 27, 2021
igorbernstein2
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ApiTracer#batchRequestThrottledto track total throttled time of a batch. InBatcherImpl, add throttled time toApiCallContextso it can be accessed from callable chains and recorded inApiTracer.