Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Fix flaky FlowControllerTest #1359

Closed
vam-google opened this issue May 1, 2021 · 2 comments
Closed

Fix flaky FlowControllerTest #1359

vam-google opened this issue May 1, 2021 · 2 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@vam-google
Copy link
Contributor

The FlowControllerTest#testConcurrentUpdateThresholds_nonBlocking seems to be very flaky. It also failed the release of gax 1.63.2 (#1357).

The buidl very often fails with an error like the following:

com.google.api.gax.batching.FlowControllerTest > testConcurrentUpdateThresholds_nonBlocking FAILED
    The maximum number of batch elements: 4850 have been reached.
        at com.google.api.gax.batching.FlowController.reserve(FlowController.java:221)
        at com.google.api.gax.batching.FlowControllerTest.testRejectedReserveRelease(FlowControllerTest.java:503)
        at com.google.api.gax.batching.FlowControllerTest.testConcurrentUpdateThresholds_nonBlocking(FlowControllerTest.java:570)
@vam-google
Copy link
Contributor Author

@mutianf PTAL

vam-google added a commit to vam-google/gax-java that referenced this issue May 1, 2021
@vam-google
fix: Remove a flacky test in FlowControllerTest
b6b6cc0 
It is a temporary workaround. More details here: googleapis#1359
@vam-google vam-google mentioned this issue May 1, 2021
Merged
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label May 2, 2021
vam-google added a commit that referenced this issue May 3, 2021
@vam-google
fix: Remove a flacky test in FlowControllerTest (#1360)
2cca0bf 
It is a temporary workaround. More details here: #1359
@vam-google vam-google mentioned this issue May 4, 2021
Merged
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 8, 2021
@vam-google vam-google added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 10, 2021
@vam-google
Copy link
Contributor Author

This has been fixed by @mutianf in #1365. Closing

@vam-google vam-google removed the 🚨 This issue needs some love. label May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vam-google @yoshi-automation