This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
feat: dynamic flow control p3: add FlowControllerEventStats #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1332 +/- ##
============================================
+ Coverage 81.31% 81.45% +0.14%
- Complexity 1338 1347 +9
============================================
Files 210 211 +1
Lines 5690 5728 +38
Branches 521 526 +5
============================================
+ Hits 4627 4666 +39
+ Misses 852 850 -2
- Partials 211 212 +1
Continue to review full report at Codecov.
|
igorbernstein2
suggested changes
Mar 22, 2021
gax/src/main/java/com/google/api/gax/batching/FlowController.java
Outdated
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Outdated
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Outdated
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Outdated
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Outdated
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Outdated
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Outdated
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Outdated
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Outdated
Show resolved
Hide resolved
igorbernstein2
approved these changes
Mar 24, 2021
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Show resolved
Hide resolved
vam-google
approved these changes
Mar 31, 2021
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Show resolved
Hide resolved
| return new AutoValue_FlowControlEventStats_FlowControlEvent(timestampMs, null, exception); | ||
| } | ||
|
|
||
| public abstract long getTimestampMs(); |
There was a problem hiding this comment.
Subjective, but it looks like this class does not need to be AutoValue. It is way less trivial than most of the AutoValue classes, which are usually just a set of setters/getters (not the case here). Please consider just storing the throttledtimeInMs, exception and timestampMs values manually in this class.
There was a problem hiding this comment.
AutoValue doesnt actually hurt anything here. I generally prefer AutoValue here to communicate the fact that this is a simple value type
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Outdated
Show resolved
Hide resolved
gax/src/test/java/com/google/api/gax/batching/FlowControlEventStatsTest.java
Outdated
Show resolved
Hide resolved
gax/src/test/java/com/google/api/gax/batching/FlowControlEventStatsTest.java
Outdated
Show resolved
Hide resolved
elharo
reviewed
Apr 1, 2021
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Show resolved
Hide resolved
| return new AutoValue_FlowControlEventStats_FlowControlEvent(timestampMs, null, exception); | ||
| } | ||
|
|
||
| public abstract long getTimestampMs(); |
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Outdated
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Outdated
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Outdated
Show resolved
Hide resolved
gax/src/main/java/com/google/api/gax/batching/FlowControlEventStats.java
Outdated
Show resolved
Hide resolved
igorbernstein2
added
kokoro:force-run
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
mutianf
force-pushed
the
dynamic_flow_control_p3
branch
from
76fdf5d
to
74eae2b
Compare
igorbernstein2
added
kokoro:force-run
igorbernstein2
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of go/veneer-dynamic-flow-control part 3, adding a class to record flow control events