Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

code should be updated as indicated in the PR comments #1323

Closed
sanjaypujare opened this issue Mar 9, 2021 · 4 comments · Fixed by #1419
Closed

code should be updated as indicated in the PR comments #1323

sanjaypujare opened this issue Mar 9, 2021 · 4 comments · Fixed by #1419
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.

Comments

@sanjaypujare
Copy link

the following things need to be fixed:

  • Not using Runtime.exec as pointed out here
  • have foolproof logic for detecting GCE that is able to clearly rule out GAE/GKE so that we don't get false positives as pointed out in this comment
@sanjaypujare sanjaypujare mentioned this issue Mar 9, 2021
Merged
@mohanli-ml mohanli-ml mentioned this issue Mar 9, 2021
Closed
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Mar 9, 2021
igorbernstein2 added a commit to igorbernstein2/gax-java that referenced this issue Jun 29, 2021
@igorbernstein2
chore: replace unnecessary exec with a simple read
40460a8 
Fixes googleapis#1323
@igorbernstein2 igorbernstein2 mentioned this issue Jun 29, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 2, 2021
@igorbernstein2
chore: replace unnecessary exec with a simple read (#1419)
7476d29 
Fixes #1323
@igorbernstein2 igorbernstein2 reopened this Jul 2, 2021
@vchudnov-g
Copy link

@sanjaypujare To clarify, you mean the code should be updated as indicated in those PR comments?

@vchudnov-g vchudnov-g added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Sep 13, 2021
@sanjaypujare sanjaypujare changed the title need to fix PR comments in the code code should be updated as indicated in the PR comments Sep 13, 2021
@sanjaypujare
Copy link
Author

@sanjaypujare To clarify, you mean the code should be updated as indicated in those PR comments?

Yes. I updated the issue header

@vam-google
Copy link
Contributor

@mohanli-ml Can you please address this (context: #1250 (comment))

@sanjaypujare
Copy link
Author

Issue seems to have been fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: replace unnecessary exec with a simple read igorbernstein2/gax-java
5 participants
@vchudnov-g @sanjaypujare @igorbernstein2 @vam-google @yoshi-automation